Skip to content

add debconfmod state back to core #67942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add debconfmod state back to core #67942

wants to merge 1 commit into from

Conversation

jeff350
Copy link

@jeff350 jeff350 commented Apr 5, 2025

What does this PR do?

This PR reintroduces the debconfmod state that was removed from the great module migrations.

Conversations have happened on the discord where @dwoz asked for this PR to be created.

What issues does this PR fix or reference?

Fixes

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

@jeff350 jeff350 requested a review from a team as a code owner April 5, 2025 02:47
@sylvainfaivre
Copy link

Hi, I don't know much about salt development so I may be wrong, but shouldn't these files be restored too ?

doc/ref/modules/all/salt.modules.debconfmod.rst
salt/modules/debconfmod.py
tests/pytests/unit/modules/test_debconfmod.py

@twangboy
Copy link
Contributor

twangboy commented Apr 9, 2025 •
edited
Loading

Hi, I don't know much about salt development so I may be wrong, but shouldn't these files be restored too ?

doc/ref/modules/all/salt.modules.debconfmod.rst
salt/modules/debconfmod.py
tests/pytests/unit/modules/test_debconfmod.py

I don't see any of these files in the holding repo. I think this is a case where the execution module didn't get removed but the state and test did. We're just putting the state and test back.

@twangboy twangboy added this to the Argon v3008.0 milestone Apr 9, 2025
@sylvainfaivre
Copy link

Hi, I don't know much about salt development so I may be wrong, but shouldn't these files be restored too ?

doc/ref/modules/all/salt.modules.debconfmod.rst
salt/modules/debconfmod.py
tests/pytests/unit/modules/test_debconfmod.py

I don't see any of these files in the holding repo. I think this is a case where the execution module didn't get removed but the state and test did. We're just putting the state and test back.

You are right, those are still in salt core, master branch.

I don't know why I thought they had been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy twangboy approved these changes

Assignees

@dwoz dwoz

Labels
None yet
Projects
None yet
Milestone
Argon v3008.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jeff350 @sylvainfaivre @twangboy @dwoz